• © Goverland Inc. 2026
  • v1.0.8
  • Privacy Policy
  • Terms of Use
Pull Request ProposalsPull Request Proposalsby0x4ff30B9BC8443415dD7A9a2AC4c5Ab1f185FB3FB0x4ff3…B3FB

#5561 Refactor/rate oracle rate sources

Voting ended over 3 years agoSucceeded

The RateOracle is currently designed in a non-OOP way, where, to add a new source, we have to make changes to the oracle itself. This PR refactors the RateOracle to extract the source-specific logic into separate components, making the code much more maintainable and testable.

In addition, also to increase maintainability and testability, the PR moves away from global access and class methods, and towards instance methods and attributes.

Changes were also made to the sources themselves to re-use already existing code when communicating with the exchanges APIs.

PR: https://github.com/hummingbot/hummingbot/pull/5561

Off-Chain Vote

For
902.73K HBOT100%
Against
0 HBOT0%
Abstain
0 HBOT0%
Quorum:1840%
Download mobile app to vote

Timeline

Aug 03, 2022Proposal created
Aug 03, 2022Proposal vote started
Aug 10, 2022Proposal vote ended
Oct 26, 2023Proposal updated