by
0x873f…b71e
#5120 Feat/separate order update from order fill in order tracker
Voting ended over 3 years agoSucceeded
This PR includes 3 changes:
- Separate the logic in the client order tracker and the generic inflight order to process trade fills separate from the order update. The correct way to use the trade fill now is to process a TradeUpdate. A trade fill will not be automatically generated any more when processing an OrderUpdate.
- Improve the client order tracker to not process an OrderUpdate that will mark the order as completely filled until all fill updates have been processed (until the order is filled regarding the amount too). This is to avoid errors in the order complete event in exchanges that send the order complete event before the last order fill event.
- Include information about already processed order fills when storing an order as JSON, and when recovering it from JSON, to avoid processing repeated fills twice in a recovered order.
Link: https://github.com/hummingbot/hummingbot/pull/5120
Off-Chain Vote
Loading…
- Author
0x873f…b71e
- IPFS#QmPT38WF
- Voting Systembasic
- Start DateFeb 20, 2022
- End DateFeb 23, 2022
- Total Votes Cast624.8K
- Total Voters2
Timeline
- Feb 16, 2022Proposal created
- Feb 20, 2022Proposal vote started
- Feb 23, 2022Proposal vote ended
- Oct 26, 2023Proposal updated