by
0x873f…b71e
#5079 fix/order tracker not match orders with undefined ids
Voting ended over 3 years agoSucceeded
PR created to solve the issue https://github.com/hummingbot/hummingbot/issues/5056 Change the fetch order logic in the client order tracker to not look for orders using the exchange order id if it has not been provided as a parameter. Without this change if the exchange order id is not specified it will be None, and the fetch method will match orders in the tracker without exchange order id. Also in this PR the update logic from a trade update has been changed to never update the exchange order id. That id should be only updated by the order update.
Link: https://github.com/hummingbot/hummingbot/pull/5079
Off-Chain Vote
Loading…
- Author
0x873f…b71e
- IPFS#QmWjCuNK
- Voting Systembasic
- Start DateFeb 20, 2022
- End DateFeb 23, 2022
- Total Votes Cast624.8K
- Total Voters2
Timeline
- Feb 16, 2022Proposal created
- Feb 20, 2022Proposal vote started
- Feb 23, 2022Proposal vote ended
- Oct 26, 2023Proposal updated