by
0x5481…B54B
fix/ `hummingbot_quickstart.py` improvements when using Gateway connector
Voting ended about 3 years agoSucceeded
This PR addresses UX issues with using hummingbot_quickstart.py
and a Gateway-reliant strategy
Link to PR: https://github.com/hummingbot/hummingbot/pull/5490
A description of the changes proposed in the pull request:
hummingbot_quickstart.py
will now not require a confirmation prompt when starting a gateway-required strategyStartCommand
now waits for the gateway service to beONLINE
before initialising a gateway-required strategy.
Tests performed by the developer:
- Add additional initialisation parameter for
HummingbotApplication
that will be used to determine if confirmation prompt is necessary - Add helper functions within the
StartCommand
class to do additional preliminary checks to ensure that Gateway service isONLINE
. - Refactor and add additional properties into
GatewayStatusMonitor
to help with the above checks. - Re-define
GatewayStatus
Enum.ONLINE
is now used to indicate that the Hummingbot client is able to receive a response from the Gateway Service, whileOFFLINE
is used to indicate otherwise.
Tips for QA testing:
- Running
hummingbot_quickstart.py
with a gateway-supported strategy would no longer be blocked by the confirmation prompt. - Any subsequent manual inputs to
start
the bot, will still require confirmation from the user. - Ensure that the bot now waits for the the gateway service to be running and online before the gateway-reliant strategy gets started.
- A 3 minute timeout is enforced to prevent the bot from waiting indefinitely
Off-Chain Vote
Loading…
- Author
0x5481…B54B
- IPFS#bafkreih
- Voting Systembasic
- Start DateJul 13, 2022
- End DateJul 20, 2022
- Total Votes Cast213.6K HBOT
- Total Voters1
Timeline
- Jul 13, 2022Proposal created
- Jul 13, 2022Proposal vote started
- Jul 20, 2022Proposal vote ended
- Oct 26, 2023Proposal updated