• © Goverland Inc. 2026
  • v1.0.8
  • Privacy Policy
  • Terms of Use
Pull Request ProposalsPull Request Proposalsby0xA04079b61AC5D834BE91Af02b87E4821E63B53a00xA040…53a0

fix/xemm decimal invalid operation error when too much quote balance

Voting ended almost 4 years agoSucceeded

Cross Exchange market making returns a "Decimal Invalid Operation" error when quote balance is too high. This is due to "taker_market.c_get_price_for_quote_volume()" being called with quote balance, and this function returns NaN when quote balance is too high.

This bug can be replicated by using paper trade. Setting balance paper to USDT 1000000, and running xemm on an illiquid market (thin order book).

Made slight changes in the code that would prevent this error from popping up. Does not affect the main logic of xemm in any way.

Off-Chain Vote

For
443.8K HBOT100%
Against
0 HBOT0%
Abstain
0 HBOT0%
Quorum:1633%
Download mobile app to vote

Timeline

Apr 12, 2022Proposal created
Apr 12, 2022Proposal vote started
Apr 19, 2022Proposal vote ended
Oct 26, 2023Proposal updated