#5088 Fix incorrect trade id in order filled event

Voting ended about 4 years agoSucceeded

This PR fixes the issue https://github.com/hummingbot/hummingbot/issues/5037

It updates the creation of OrderFilledEvent instances in all the connectors that were doing that without specifying the trade id, or using the order id as trade id. The change will allow those connectors to register several partial fills to the same order without failing.

Impacted connectors:

DyDx perpetual
Beaxy
Bitfinex
Bittrex
Blocktane
Coinbase Pro
Crypto com
Digifinex
Huobi
K2
Kucoin
Liquid
Loopring
Mexc
Okex

It also impacts the paper trade logic.

Link: https://github.com/hummingbot/hummingbot/pull/5088

Off-Chain Vote

For

10.25M 100%

Against

0 0%

Abstain

0 0%

Download mobile app to vote

Timeline

Feb 03, 2022Proposal created

Feb 07, 2022Proposal vote started

Feb 10, 2022Proposal vote ended

Oct 26, 2023Proposal updated