• © Goverland Inc. 2026
  • v1.0.3
  • Privacy Policy
  • Terms of Use
Pull Request ProposalsPull Request Proposalsby0x873f2CCFEB3C10154067DF4F3ADf67242c62b71e0x873f…b71e

#5079 Fix Binance Conflicting Trade Order Information

Voting ended almost 4 years agoSucceeded

PR created to solve the issue https://github.com/hummingbot/hummingbot/issues/5056

Changed the fetch order logic in the client order tracker to not look for orders using the exchange order id if it has not been provided as a parameter. Without this change if the exchange order id is not specified it will be None, and the fetch method will match orders in the tracker without exchange order id.

Also in this PR the update logic from a trade update has been changed to never update the exchange order id. That id should be only updated by the order update.

Link: https://github.com/hummingbot/hummingbot/pull/5079

Off-Chain Vote

For
862.02K 100%
Against
0 0%
Abstain
0 0%
Download mobile app to vote

Timeline

Feb 03, 2022Proposal created
Feb 07, 2022Proposal vote started
Feb 10, 2022Proposal vote ended
Oct 26, 2023Proposal updated