• © Goverland Inc. 2026
  • v1.0.3
  • Privacy Policy
  • Terms of Use
Pull Request ProposalsPull Request Proposalsby0x873f2CCFEB3C10154067DF4F3ADf67242c62b71e0x873f…b71e

#5067 Refactor PaperTradeExchange to use the BudgetChecker when simulating order fills

Voting ended almost 4 years agoSucceeded
  • MarketConfig was replaced by BudgetChecker for fee calculation and portfolio constraints checks

  • Currently fees are calculated directly in the PaperTradeExchange class where also budget checks take place. The implementation is incomplete, for certain orders fees are not calculated at all, and for all cases, fee asset is fixed and assumed to be the same for all exchanges, which is not true. BudgetChecker provides a comprehensive solution for all these issues, it calculates all fees, checks budget constraints and retrieves the correct fee asset from exchanges. As a result, the simulated trading by the PaperTradeExchange will become more accurate.

Link: https://github.com/hummingbot/hummingbot/pull/5067

Off-Chain Vote

For
645.1K 100%
Against
0 0%
Abstain
0 0%
Download mobile app to vote

Timeline

Feb 03, 2022Proposal created
Feb 07, 2022Proposal vote started
Feb 10, 2022Proposal vote ended
Oct 26, 2023Proposal updated