by
0x873f…b71e
#5067 Refactor PaperTradeExchange to use the BudgetChecker when simulating order fills
Voting ended over 3 years agoSucceeded
-
MarketConfig was replaced by BudgetChecker for fee calculation and portfolio constraints checks
-
Currently fees are calculated directly in the PaperTradeExchange class where also budget checks take place. The implementation is incomplete, for certain orders fees are not calculated at all, and for all cases, fee asset is fixed and assumed to be the same for all exchanges, which is not true. BudgetChecker provides a comprehensive solution for all these issues, it calculates all fees, checks budget constraints and retrieves the correct fee asset from exchanges. As a result, the simulated trading by the PaperTradeExchange will become more accurate.
Link: https://github.com/hummingbot/hummingbot/pull/5067
Off-Chain Vote
Loading…
- Author
0x873f…b71e
- IPFS#QmSnC89i
- Voting Systembasic
- Start DateFeb 07, 2022
- End DateFeb 10, 2022
- Total Votes Cast645.1K
- Total Voters5
Timeline
- Feb 03, 2022Proposal created
- Feb 07, 2022Proposal vote started
- Feb 10, 2022Proposal vote ended
- Oct 26, 2023Proposal updated