• © Goverland Inc. 2026
  • v1.0.3
  • Privacy Policy
  • Terms of Use
Pull Request ProposalsPull Request Proposalsby0x873f2CCFEB3C10154067DF4F3ADf67242c62b71e0x873f…b71e

#5160 feat/allow fees in different tokens

Voting ended almost 4 years agoSucceeded

In this PR we introduce the required changes for the client to accept having fees for a trade in different tokens (something that happens with Binance connector, that sometimes can charge fees in BNB and sometimes in the trade quote token).

The changes include:

  • Remove fee_amount and fee_token from the order complete events, since that information was not being used anywhere
  • Change PNL calculation logic to convert fees in different tokens to the quote token using the RateOracle as price provider
  • Modification of the start command to always start also the RateOracle, for it to regularly update prices

Link: https://github.com/hummingbot/hummingbot/pull/5160

Off-Chain Vote

For
755.18K 100%
Against
0 0%
Abstain
0 0%
Download mobile app to vote

Timeline

Mar 07, 2022Proposal created
Mar 11, 2022Proposal vote started
Mar 14, 2022Proposal vote ended
Oct 26, 2023Proposal updated