by
0x873f…b71e
#5160 feat/allow fees in different tokens
Voting ended over 3 years agoSucceeded
In this PR we introduce the required changes for the client to accept having fees for a trade in different tokens (something that happens with Binance connector, that sometimes can charge fees in BNB and sometimes in the trade quote token).
The changes include:
- Remove fee_amount and fee_token from the order complete events, since that information was not being used anywhere
- Change PNL calculation logic to convert fees in different tokens to the quote token using the RateOracle as price provider
- Modification of the start command to always start also the RateOracle, for it to regularly update prices
Link: https://github.com/hummingbot/hummingbot/pull/5160
Off-Chain Vote
Loading…
- Author
0x873f…b71e
- IPFS#QmTZaicz
- Voting Systembasic
- Start DateMar 11, 2022
- End DateMar 14, 2022
- Total Votes Cast755.18K
- Total Voters2
Timeline
- Mar 07, 2022Proposal created
- Mar 11, 2022Proposal vote started
- Mar 14, 2022Proposal vote ended
- Oct 26, 2023Proposal updated