• © Goverland Inc. 2026
  • v1.0.8
  • Privacy Policy
  • Terms of Use
HummingbotHummingbotby0x58B7AA5bEd029A5D149E108Ad4bdF836D10F70Ea0x58B7…70Ea

#4968 fix/rounding for balance over hundred percent

Voting ended about 4 years agoSucceeded

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings You are using approved title ("feat/", "fix/", "docs/", "refactor/") A description of the changes proposed in the pull request:

The changes presented in this PR are expected to fix the issue shown at #4946, which is caused by rounding errors at operations, as smart rounding could lead to lower values for the divisor of the operation which result is shown.

Tests performed by the developer:

The test is expected to be run by the issue creator as I could not replicate the scenario with my current configuration of the application. If there is any way to simulate the scenario without having wallets please let me know.

Warning These changes only could be merged after being tested by the issue creator or any other HummingBot community member.

Tips for QA testing:

No additional recommendations are brought taking into account the slightness of the modifications.

PR Link: https://github.com/hummingbot/hummingbot/pull/4968

Off-Chain Vote

For
2.89M 100%
Against
0 0%
Abstain
0 0%
Download mobile app to vote

Timeline

Dec 30, 2021Proposal created
Jan 03, 2022Proposal vote started
Jan 06, 2022Proposal vote ended
Oct 26, 2023Proposal updated